Comment 21 for bug 1821755

Reviewed: https://review.opendev.org/c/openstack/nova/+/800114
Committed: https://opendev.org/openstack/nova/commit/5fa8718fe57e59b178d081e2068109151fdc3926
Submitter: "Zuul (22348)"
Branch: stable/stein

commit 5fa8718fe57e59b178d081e2068109151fdc3926
Author: Rodrigo Barbieri <email address hidden>
Date: Wed Mar 31 11:06:49 2021 -0300

    Error anti-affinity violation on migrations

    Error-out the migrations (cold and live) whenever the
    anti-affinity policy is violated. This addresses
    violations when multiple concurrent migrations are
    requested.

    Added detection on:
    - prep_resize
    - check_can_live_migration_destination
    - pre_live_migration

    The improved method of detection now locks based on group_id
    and considers other migrations in-progress as well.

    Conflicts:
        nova/tests/unit/compute/test_compute_mgr.py

    NOTE: Conflicts are because the following changes are not in Stein:

      * Ia00277ac8a68a635db85f9e0ce2c6d8df396e0d8 (Set migrate_data.vifs only when using multiple port bindings)
      * I3c917796cb30d11e7db1e235ac1625d2a743aaa2 (NUMA live migration support)
      * I2f3434f06489d8b6cb80933bcb1ea1e841049ba5 (Support migrating SRIOV port with bandwidth)
      * I292a0e2d840bbf657ba6d0932f9a3decbcb2778f ([FUP] Follow-up patch for SR-IOV live migration)
      * I734cc01dce13f9e75a16639faf890ddb1661b7eb (SR-IOV Live migration indirect port support)

    Summary of conflicts:

    Cherry-picked pulled many non-related newer unit tests.
    Cleaned those up and adjusted:
    - Removed 2 extra params of check_can_live_migrate_destination
      invocations.
    - Adjusted request_spec variable of
      unit test test_prep_resize_errors_migration.
    - Removed extra tab spacing on a unit test.

    Closes-bug: #1821755
    Change-Id: I32e6214568bb57f7613ddeba2c2c46da0320fabc
    (cherry picked from commit 33c8af1f8c46c9c37fcc28fb3409fbd3a78ae39f)
    (cherry picked from commit 8b62a4ec9bf617dfb2da046c25a9f76b33516508)
    (cherry picked from commit 6ede6df7f41db809de19e124d3d4994180598f19)
    (cherry picked from commit bf90a1e06181f6b328b967124e538c6e2579b2e5)
    (cherry picked from commit a22d1b04de9e6ebc33b5ab9871b86f8e4022e7a9)