commit 71df650d0a390d2b6b19928db4379e723e9f5cde
Author: Dan Smith <email address hidden>
Date: Thu Mar 14 14:07:31 2019 -0700
Avoid crashing while getting libvirt capabilities with unknown arch names
In _get_instance_capabilities() we get a list of host capabilities and then
build a list of arches supported by the virt type of an instance to arrive
at the list of possibilities for the instance. We check each of those
against our enum, but fail to gracefully skip unsupported values should we
encounter one.
This patch makes that graceful, and also introduces an unsupported arch to
the test stub to make sure we always skip it. Note that we do not warn
because this happens once per instance in a periodic task, and since the
situation is caused by a (somewhat permanent) mismatch of libvirt and
nova version support, isn't something that needs to be remedied by an
operator.
Reviewed: https:/ /review. openstack. org/643458 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=71df650d0a3 90d2b6b19928db4 379e723e9f5cde
Committed: https:/
Submitter: Zuul
Branch: master
commit 71df650d0a390d2 b6b19928db4379e 723e9f5cde
Author: Dan Smith <email address hidden>
Date: Thu Mar 14 14:07:31 2019 -0700
Avoid crashing while getting libvirt capabilities with unknown arch names
In _get_instance_ capabilities( ) we get a list of host capabilities and then
build a list of arches supported by the virt type of an instance to arrive
at the list of possibilities for the instance. We check each of those
against our enum, but fail to gracefully skip unsupported values should we
encounter one.
This patch makes that graceful, and also introduces an unsupported arch to
the test stub to make sure we always skip it. Note that we do not warn
because this happens once per instance in a periodic task, and since the
situation is caused by a (somewhat permanent) mismatch of libvirt and
nova version support, isn't something that needs to be remedied by an
operator.
Closes-Bug: #1820125 f903a5793ad5f3a e9d06f085f4
Change-Id: I5d95bd50279a6b