The confirm resize flow in the compute manager
runs on the source host. It calls RT.drop_move_claim
to drop resource usage from the source host for the
old flavor. The problem with drop_move_claim is it
only decrements the old flavor from the reported usage
if the instance is in RT.tracked_migrations, which will
only be there on the source host if the update_available_resource
periodic task runs before the resize is confirmed, otherwise
the instance is still just tracked in RT.tracked_instances on
the source host. This leaves the source compute incorrectly
reporting resource usage for the old flavor until the next
periodic runs, which could be a large window if resizes are
configured to automatically confirm, e.g. resize_confirm_window=1,
and the periodic interval is big, e.g. update_resources_interval=600.
This change adds a functional recreate test for the bug which will
be updated in the change that fixes the bug.
Reviewed: https:/ /review. opendev. org/641521 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=54877e06f13 b13134f2030557c d779f947a43c24
Committed: https:/
Submitter: Zuul
Branch: master
commit 54877e06f13b131 34f2030557cd779 f947a43c24
Author: Matt Riedemann <email address hidden>
Date: Wed Mar 6 18:46:22 2019 -0500
Add functional recreate test for bug 1818914
The confirm resize flow in the compute manager migrations, which will available_ resource instances on confirm_ window= 1, resources_ interval= 600.
runs on the source host. It calls RT.drop_move_claim
to drop resource usage from the source host for the
old flavor. The problem with drop_move_claim is it
only decrements the old flavor from the reported usage
if the instance is in RT.tracked_
only be there on the source host if the update_
periodic task runs before the resize is confirmed, otherwise
the instance is still just tracked in RT.tracked_
the source host. This leaves the source compute incorrectly
reporting resource usage for the old flavor until the next
periodic runs, which could be a large window if resizes are
configured to automatically confirm, e.g. resize_
and the periodic interval is big, e.g. update_
This change adds a functional recreate test for the bug which will
be updated in the change that fixes the bug.
Change-Id: I4aac187283c2f3 41b5c2712be85f7 22156e14f63
Related-Bug: #1818914
Related-Bug: #1498126