Comment 2 for bug 1809418

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/626853
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=47937b6113dfe34202926536a2c43d3f85676026
Submitter: Zuul
Branch: master

commit 47937b6113dfe34202926536a2c43d3f85676026
Author: int32bit <email address hidden>
Date: Fri Dec 21 15:35:36 2018 +0800

    Convert port to str when validate console port

    The port type must be str type in nova-serialproxy side as we convert to str
    forcefully before rpc validate_console to compute service[1]. But on the
    compute side, the driver may be return int type like ironic serial console[2].
    So the validate_console_port may always return False as type inconsistence[3].

    [1] https://github.com/openstack/nova/blob/18.0.0/nova/console/websocketproxy.py#L144
    [2] https://github.com/openstack/nova/blob/18.0.0/nova/virt/ironic/driver.py#L1830
    [3] https://github.com/openstack/nova/blob/18.0.0/nova/compute/manager.py#L5417

    Closes-Bug: 1809418

    Change-Id: If5f3dc725c5836e67d09deeefb3bce2249f71a69