Comment 7 for bug 1797146

Reviewed: https://review.opendev.org/667355
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0142cc840f6680e5011381c6793173ebd0c9ee1e
Submitter: Zuul
Branch: stable/rocky

commit 0142cc840f6680e5011381c6793173ebd0c9ee1e
Author: Stephen Finucane <email address hidden>
Date: Wed Oct 10 16:29:40 2018 +0100

    Ignore hw_vif_type for direct, direct-physical vNIC types

    As part of the fix for bug #1789074, we stopped setting the VIF model to
    virtio for a vif_type of 'direct' or 'direct-physical'. However, if
    users configured the 'hw_vif_type' image metadata property, the VIF
    model would be unconditionally set to whatever the user provided. This
    would result in bug #1789074 recurring. Given that the model attribute
    is unnecessary for these vNIC types, we can resolve this issue by
    simply ignoring the image metadata property when configuring such VIFs.

    Change-Id: I3bf5587c3a49c807bb14533dbbea8f72dca2f02b
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-bug: #1797146
    (cherry picked from commit a235451578ad7af25268e82500dff5ba6a64ea4e)
    (cherry picked from commit d78310e67a8fcf59465907eddecba4f5145a0a6f)