Comment 14 for bug 1795064

Reviewed: https://review.openstack.org/635921
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8049e9595bfcf041cd81a4dd353f6285a9806100
Submitter: Zuul
Branch: stable/pike

commit 8049e9595bfcf041cd81a4dd353f6285a9806100
Author: Matt Riedemann <email address hidden>
Date: Wed Oct 3 12:54:53 2018 -0400

    Handle IndexError in _populate_neutron_binding_profile

    This fixes the code that was blindly pop'ing an entry
    from an empty list of PCI devices claimed by the instance.
    It's not exactly clear how we can get into this situation,
    presumably there was a failure in the actual PCI device
    claim logic in the ResourceTracker - maybe related to the
    configured PCI passthrough whitelist. Regardless, we should
    handle the empty PCI device list in this method and raise
    an appropriate exception to fail the build on this host.

    Conflicts:
     nova/network/neutronv2/api.py

    Note(elod.illes): conflict caused by two change not part of
    branch stable/pike: Id847949b4761d51a14e5c2f39552f60a47889aa9
    and Ie3a83fef0dc689b9d37ac43e047ce5d48f567adc

    Change-Id: I401bb74cf6e17c2b72cc62bf8ec03ec58238c44a
    Closes-Bug: #1795064
    (cherry picked from commit 035708c37d587e4c5ede7fe80270bdbff98016ac)
    (cherry picked from commit dfbcf5e40bb51813f56f983e4f75e29a6034a830)
    (cherry picked from commit 8369a78af07b224f109586de398c702db342b49d)