Comment 14 for bug 1771700

Reviewed: https://review.openstack.org/571433
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cd862fe8ef52719422940e05955ffffb6b073b96
Submitter: Zuul
Branch: stable/ocata

commit cd862fe8ef52719422940e05955ffffb6b073b96
Author: Lee Yarwood <email address hidden>
Date: Thu May 17 09:47:58 2018 +0100

    libvirt: Skip fetching the virtual size of block devices

    In this latest episode of `Which CI job has lyarwood broken today?!` we
    find that I464bc2b88123a012cd12213beac4b572c3c20a56 introduced a
    regression in the nova-lvm experimental job as n-cpu attempted to run
    qemu-img info against block devices as an unprivileged user.

    For the time being we should skip any attempt to use this command
    against block devices until the disk_api layer can make privileged
    calls using privsep.

    Conflicts:
            nova/virt/libvirt/driver.py
            nova/tests/unit/virt/libvirt/test_driver.py

    NOTE(lyarwood): Conflicts due to the substantial refactoring of
    _get_instance_disk_info via I9616a602ee0605f7f1dc1f47b6416f01895e025b,
    for this change the test has been extended to provide valid XML via the
    config classes.

    Closes-bug: #1771700
    Change-Id: I9653f81ec716f80eb638810f65e2d3cdfeedaa22
    (cherry picked from commit fda48219a378d09a9a363078ba161d7f54e32c0a)
    (cherry picked from commit 8ea98c56b647526aae7a786531e934eeee7a90a2)
    (cherry picked from commit 43cac615f6a0a4399c7bf3dda6c2595749f27ace)