Prior to this patch, if the openssl command returned a zero exit code
and wrote details to stderr, nova would raise a RuntimeError exception.
This patch changes the behavior to only raise a RuntimeError exception
when openssl returns a non-zero exit code. Regardless of the exit code
a warning will always be logged with stderr details if stderr is not
None. Note that processutils.execute will now raise a
processutils.ProcessExecutionError exception for any non-zero exit code
since we are passing check_exit_code=True, which we convert to a
Runtime error.
Thanks to Dimitri John Ledkov <email address hidden> and Eric Fried
<email address hidden> for helping with this patch.
Reviewed: https:/ /review. opendev. org/635533 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=1da71fa4ab1 d7d0f580cd5cbc9 7f2dfd2e1c378a
Committed: https:/
Submitter: Zuul
Branch: master
commit 1da71fa4ab1d7d0 f580cd5cbc97f2d fd2e1c378a
Author: Corey Bryant <email address hidden>
Date: Thu Feb 7 10:12:54 2019 -0500
xenapi/agent: Change openssl error handling
Prior to this patch, if the openssl command returned a zero exit code execute will now raise a s.ProcessExecut ionError exception for any non-zero exit code code=True, which we convert to a
and wrote details to stderr, nova would raise a RuntimeError exception.
This patch changes the behavior to only raise a RuntimeError exception
when openssl returns a non-zero exit code. Regardless of the exit code
a warning will always be logged with stderr details if stderr is not
None. Note that processutils.
processutil
since we are passing check_exit_
Runtime error.
Thanks to Dimitri John Ledkov <email address hidden> and Eric Fried
<email address hidden> for helping with this patch.
Change-Id: I212ac2b5ccd93e 00adb7b9fe102fc b70857c6073
Partial-Bug: #1771506