commit 80a001989351d3d427c204c8c06cfacc964f2a35
Author: Matt Riedemann <email address hidden>
Date: Thu May 3 11:21:47 2018 -0400
Handle @safe_connect returns None side effect in _ensure_resource_provider
Change I0c4ca6a81f213277fe7219cb905a805712f81e36 added more error
handling to the _ensure_resource_provider flow but didn't account
for @safe_connect returning None when calling _create_resource_provider
in the case that nova-compute is started before placement is running.
If that happens, we fail with a TypeError during the nova-compute
startup because we put None in the resource provider cache and then
later blindly try to use it because the compute node resource provider
uuid is in the cache, but mapped to None.
This adds the None check back in _ensure_resource_provider and if
None is returned from _create_resource_provider we raise the same
exception that _create_resource_provider would raise if it couldn't
create the provider.
Reviewed: https:/ /review. openstack. org/566096 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=80a00198935 1d3d427c204c8c0 6cfacc964f2a35
Committed: https:/
Submitter: Zuul
Branch: master
commit 80a001989351d3d 427c204c8c06cfa cc964f2a35
Author: Matt Riedemann <email address hidden>
Date: Thu May 3 11:21:47 2018 -0400
Handle @safe_connect returns None side effect in _ensure_ resource_ provider
Change I0c4ca6a81f2132 77fe7219cb905a8 05712f81e36 added more error resource_ provider flow but didn't account resource_ provider
handling to the _ensure_
for @safe_connect returning None when calling _create_
in the case that nova-compute is started before placement is running.
If that happens, we fail with a TypeError during the nova-compute
startup because we put None in the resource provider cache and then
later blindly try to use it because the compute node resource provider
uuid is in the cache, but mapped to None.
This adds the None check back in _ensure_ resource_ provider and if resource_ provider we raise the same resource_ provider would raise if it couldn't
None is returned from _create_
exception that _create_
create the provider.
Change-Id: If9e1581db9c1ae 14340b787d03c81 5d243d5a50c
Closes-Bug: #1767139