Comment 2 for bug 1766661

Revision history for this message
Julia Kreger (juliaashleykreger) wrote :

So a few different things, and my apologies if this comes across as a stream of consciousness.

1) Ironic has moved to https://storyboard.openstack.org for bug/work tracking, you'll need to open an issue there, but first read this entire reply.

2) This is partially by design. Ironic expects a "mac" address entry in the volume connector information stored in Ironic to represent available ports to be used. This was intended to allow for deployments with multiple network attachments, and to be able to declare what the address would be that is acceptable for storage interface use.

3) Given that the host key is required, the ironic virt driver code will need to be updated. Right now it only does it if it has an IP for iscsi, but it looks like fibrechannel types also require it.

4) There is another bug in that we don't save this information across TO ironic. This is important in that ironic will delete/re-add attachment data to cinder if a node is power cycled. This also allows a node to be turned off and SAN attachments removed, which would be important if a node is powered off for a long period of time. Given the volume connector data is agnostic, I think we could add a "host" key type to the storage interface (this is where opening an item over in ironic land is needed), and then we could just likely wipe those connectors upon tear_down of the instance. Perhaps as a "host" key which is not one we explicitly document and could always change anyways, so it would make sense. Relatively the first part of that in the handling on the ironic side seems reasonable and easy. Saving the data to nova seems like it might be a little more complex, but if we have the host volume connector type being wiped by default on tear_down, then I think it would be okay.