OpenStack Compute (nova)

  1. Bug #1754360
  2. Comment #11

Comment 11 for bug 1754360

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/605884
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1535d42ea14503db63d34ac47dc8ae231e0edf59
Submitter: Zuul
Branch: stable/ocata

commit 1535d42ea14503db63d34ac47dc8ae231e0edf59
Author: Eric M Gonzalez <email address hidden>
Date: Thu Mar 8 09:11:25 2018 -0600

    unquiesce instance after quiesce failure

    If the call to compute_rpcapi.quisece_instance() raises an exception,
    any uncaught exception will break out of the function
    snapshot_volume_backed(). This can leave the instance in frozen state.

    This patch adds a blanket Exception catch to the try block and calls
    compute_rpcapi.unquiesce_instance() before reraising.

    This has been seen in the wild with RPC timeouts, but this is not the
    only possible genesis for an unknown error from quiesce_instance.

    Conflicts:
          nova/tests/unit/compute/test_compute_api.py

    NOTE(mriedem): The conflict is due to not having change
    I4e7b46deb43c0c2430b480f1a498a52fc4a9daf0, and its dependencies,
    in Pike.

    Change-Id: Idca5998da8bb42b29a8fffdf52b4af3a043c6326
    Closes-Bug: #1754360
    (cherry picked from commit 1e77faaa412ab9909dd9491cab4a819b5c84d3e8)
    (cherry picked from commit bcae081c4672a13eb1a75d1d3d81a439b5fdb796)
    (cherry picked from commit 1487ea7abb974650d5658b29e52e0b0603751556)