commit cab811b89030d6e49f8ef85e29783fce94c763fc
Author: Chris Dent <email address hidden>
Date: Fri Feb 2 15:34:59 2018 +0000
Don't rely on parse.urlencode in url comparisons
The tests for allocation_candidates query parameters in test_report.py
relied on urlencode with a dict arg to create the expected_url that is
compared with the actual URL that the report client creates when
communicating with the placement service.
This is risky because the ordering of the query parameters is
not reliable when the source data is a dict. This change expands
the tests where it was used to do more explicit comparisons.
Reviewed: https:/ /review. openstack. org/540420 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=cab811b8903 0d6e49f8ef85e29 783fce94c763fc
Committed: https:/
Submitter: Zuul
Branch: master
commit cab811b89030d6e 49f8ef85e29783f ce94c763fc
Author: Chris Dent <email address hidden>
Date: Fri Feb 2 15:34:59 2018 +0000
Don't rely on parse.urlencode in url comparisons
The tests for allocation_ candidates query parameters in test_report.py
relied on urlencode with a dict arg to create the expected_url that is
compared with the actual URL that the report client creates when
communicating with the placement service.
This is risky because the ordering of the query parameters is
not reliable when the source data is a dict. This change expands
the tests where it was used to do more explicit comparisons.
Change-Id: I2e51a4574b20c0 634ad83a53c0e68 261bbf0ac82
Closes-Bug: #1747001