Comment 16 for bug 1739325

Reviewed: https://review.openstack.org/580523
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=06387be5907f3b9f05bded85ff3d3bec132fb60b
Submitter: Zuul
Branch: stable/pike

commit 06387be5907f3b9f05bded85ff3d3bec132fb60b
Author: Matt Riedemann <email address hidden>
Date: Tue Jul 3 13:03:54 2018 -0400

    Default embedded instance.flavor.disabled attribute

    Before we stored flavors in instance_extra, certain fields, defined
    in nova.compute.flavors.system_metadata_flavor_props, were stored
    in the instance.system_metadata for the embedded instance.flavor.
    The "disabled" field wasn't one of those keys, however, so really
    old instances that had their embedded flavor converted to the
    serialized instance_extra form won't have the disabled attribute
    set and we need to default those here so callers, like the
    versioned notfication FlavorPayload, don't explode trying to load
    instance.flavor.disabled.

    Change-Id: I72f8c11b8b2df1416dec8e2d9250eac0693a30e9
    Closes-Bug: #1739325
    (cherry picked from commit 8df21c1e5fc46f2774a7653e1c9a4c2ac0b5dbfd)
    (cherry picked from commit b2146b02a943c784b6c6fe19ec9e5247bd8e503d)