commit d72b33b986525a9b2c7aa08b609ae386de1d0e89
Author: Matthew Booth <email address hidden>
Date: Sat Dec 16 20:27:08 2017 +0000
Fix an error in _get_host_states when deleting a compute node
_get_host_states returns a generator which closes over seen_nodes, which
is local, and self.host_state_map, which is global. It also modifies
self.host_state_map, and will remove entries whose compute nodes are no
longer present.
If a compute node is deleted while a filter is still evaluating the
generator returned by _get_host_states, the entry in self.host_state_map
will be deleted if _get_host_states is called again. This will cause a
KeyError when the first generator comes to evaluate the entry for the
deleted compute node.
We fix this by modifying the returned generator expression to check
that a host_state_map entry still exists before returning it. An
existing unit test is modified to exhibit the bug.
Reviewed: https:/ /review. openstack. org/529352 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=d72b33b9865 25a9b2c7aa08b60 9ae386de1d0e89
Committed: https:/
Submitter: Zuul
Branch: master
commit d72b33b986525a9 b2c7aa08b609ae3 86de1d0e89
Author: Matthew Booth <email address hidden>
Date: Sat Dec 16 20:27:08 2017 +0000
Fix an error in _get_host_states when deleting a compute node
_get_ host_states returns a generator which closes over seen_nodes, which state_map, which is global. It also modifies host_state_ map, and will remove entries whose compute nodes are no
is local, and self.host_
self.
longer present.
If a compute node is deleted while a filter is still evaluating the
generator returned by _get_host_states, the entry in self.host_state_map
will be deleted if _get_host_states is called again. This will cause a
KeyError when the first generator comes to evaluate the entry for the
deleted compute node.
We fix this by modifying the returned generator expression to check
that a host_state_map entry still exists before returning it. An
existing unit test is modified to exhibit the bug.
Change-Id: Ibb7c43a0abc433 f93fc3de7114626 3e6d5923666
Closes-Bug: #1739323