Comment 12 for bug 1739318

Reviewed: https://review.openstack.org/529385
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7f8a14dbc88f8bb99d6a9da8eab8b16b067603ee
Submitter: Zuul
Branch: stable/pike

commit 7f8a14dbc88f8bb99d6a9da8eab8b16b067603ee
Author: Matt Riedemann <email address hidden>
Date: Tue Dec 19 18:40:31 2017 -0500

    Workaround missing RequestSpec.project_id when moving an instance

    The online data migration routine to create request specs for old
    instances used an admin context which has an empty project_id,
    so when scheduling (moving) one of these, if we try to PUT /allocations
    in placement using the FilterScheduler we'll fail because the project_id
    is None.

    This works around that by putting the instance.project_id on the request
    spec before calling the scheduler to pick a node and claim resources
    against it.

    A later change will need to add some sort of online data migration
    routine so that we properly update and persist the fix for these
    older records.

    Conflicts:
          nova/conductor/manager.py
          nova/conductor/tasks/live_migrate.py
          nova/conductor/tasks/migrate.py
          nova/tests/unit/conductor/test_conductor.py

    NOTE(mriedem): The conflicts are due to
    ca716ce4dd512e864886998a24e111e7d6e05848 and
    685c16041c7e84fb0861b9b1833fc6c3cc372d05 not
    being in Pike.

    Change-Id: I34b1d99a9d0d2aca80f094a79ec1656abaf762dc
    Partial-Bug: #1739318
    (cherry picked from commit f9a06c42535ef7ebba92c793afd947073352f850)