OpenStack Compute (nova)

  1. Bug #1732199
  2. Comment #22

Comment 22 for bug 1732199

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (stable/pike)

Reviewed: https://review.openstack.org/643400
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=c183991a5ce3c9af8c3d5960b2fef2e45738cfdd
Submitter: Zuul
Branch: stable/pike

commit c183991a5ce3c9af8c3d5960b2fef2e45738cfdd
Author: imacdonn <email address hidden>
Date: Tue Sep 25 03:40:31 2018 +0000

    'iscsiadm -m session' failure handling

    Sometimes 'iscsiadm -m session' outputs warnings on stderr, but
    still serves its purpose (usable stdout). We should not give up on
    it when stderr is non-empty - instead, rely on the exit status, log
    the stderr as a warning, and move on.

    This change also removes 1 (ISCSI_ERR) from the list of acceptable
    exit codes for the iscsiadm command, to ensure that failures get
    caught.

    Change-Id: Id8183cf3d8baf2f8ba6a00a47fa2ad7cc2a96aa5
    Closes-Bug: #1732199
    (cherry picked from commit d398fa82334bbabbc4c7d5b8f1fe5a7a4465200e)