commit add69c05072b4ee7efd4e75debf2172ed2269c86
Author: Dan Smith <email address hidden>
Date: Fri Oct 6 07:40:42 2017 -0700
Always put 'uuid' into sort_keys for stable instance lists
If we're listing by sort keys that yield many ambiguous results, we
may exacerbate issues in client pagination because we're not even
bound by insertion order given that we have multiple databases being
queried in parallel. So, even if the client didn't ask for it, throw
'uuid' into the end of sort_keys to provide us a stable ordering. This
was done for the default case by always including 'id' in the default
set of sort_keys, although a user could still break if they request
their own keys.
Note this also removes the recently-added explicit sort in the
test_bug_1689692 case, since we're enforcing a strict ordering with
this patch. Also, mriedem is awesome.
Reviewed: https:/ /review. openstack. org/510140 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=add69c05072 b4ee7efd4e75deb f2172ed2269c86
Committed: https:/
Submitter: Jenkins
Branch: master
commit add69c05072b4ee 7efd4e75debf217 2ed2269c86
Author: Dan Smith <email address hidden>
Date: Fri Oct 6 07:40:42 2017 -0700
Always put 'uuid' into sort_keys for stable instance lists
If we're listing by sort keys that yield many ambiguous results, we
may exacerbate issues in client pagination because we're not even
bound by insertion order given that we have multiple databases being
queried in parallel. So, even if the client didn't ask for it, throw
'uuid' into the end of sort_keys to provide us a stable ordering. This
was done for the default case by always including 'id' in the default
set of sort_keys, although a user could still break if they request
their own keys.
Note this also removes the recently-added explicit sort in the bug_1689692 case, since we're enforcing a strict ordering with
test_
this patch. Also, mriedem is awesome.
Change-Id: Ida446acb1286a8 b215451a5d8d7d2 3882643ef13
Closes-Bug: #1721791