bdm is wastefully loaded for versioned instance notifications
Bug #1718226 reported by
Balazs Gibizer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Balazs Gibizer |
Bug Description
The block device mapping is included in the instance versioned notifications with I18e7483ec9a484
Changed in nova: | |
assignee: | nobody → Balazs Gibizer (balazs-gibizer) |
tags: | added: notifications |
Changed in nova: | |
status: | New → In Progress |
Changed in nova: | |
assignee: | Balazs Gibizer (balazs-gibizer) → Matt Riedemann (mriedem) |
Changed in nova: | |
assignee: | Matt Riedemann (mriedem) → Balazs Gibizer (balazs-gibizer) |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/483324 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=c4fadfd4d29 0f1083ab520aed9 20eeff552e15c4
Committed: https:/
Submitter: Jenkins
Branch: master
commit c4fadfd4d290f10 83ab520aed920ee ff552e15c4
Author: Balazs Gibizer <email address hidden>
Date: Thu Jul 13 14:06:13 2017 +0200
use already loaded BDM in instance.<action>
In I18e7483ec9a484 a660e1d306fdc09 86e1d5f952b BDM was added to the instance about_instance_ action is called to send the notification. In this cases
notifications. In general to add BDM to the payload an exta DB query is
needed. However in some places the BDM is already separately before the
notify_
loading the BDM again is unnecessary as the already loaded BDM can be reused.
This patch makes sure that notify_ about_instance_ action is called with the
already loaded BDM. There will be subsequent patches to do the same with
other notify calls.
Change-Id: I391554d3904a5a 60b921ef4714a1c fd0a64a25c2
Related-Bug: #1718226