Doing some investigation into this bug, I've found that the code that creates the XML snippet for disk devices hasn't changed in 2+ years.
The code is now in nova/virt/libvirt/migration.py now, but the code used to be in libvirt/driver.py. Sahid's refactoring patches to break driver.py into separate modules moved a lot of this code around but did not functionally change the code.
This particular section was moved in the following patch:
What is strange to me is that this bug is only recently being reported. I can't imagine that this has been buggy for 2+ years and nobody has previously noticed.
Doing some investigation into this bug, I've found that the code that creates the XML snippet for disk devices hasn't changed in 2+ years.
The code is now in nova/virt/ libvirt/ migration. py now, but the code used to be in libvirt/driver.py. Sahid's refactoring patches to break driver.py into separate modules moved a lot of this code around but did not functionally change the code.
This particular section was moved in the following patch:
https:/ /github. com/openstack/ nova/commit/ 23191308ff1bb15 1e441e398d69e46 fb845f4e65
I remember reviewing the patch in Gerrit. :)
https:/ /review. openstack. org/#/c/ 299490/
What is strange to me is that this bug is only recently being reported. I can't imagine that this has been buggy for 2+ years and nobody has previously noticed.