Comment 4 for bug 1700359

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/477212
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=e7b84daa8774434f3b1382ce40741bebe248de12
Submitter: Jenkins
Branch: master

commit e7b84daa8774434f3b1382ce40741bebe248de12
Author: Matt Riedemann <email address hidden>
Date: Sun Jun 25 09:43:12 2017 -0400

    Deprecate binary argument in nova service enable/disable/force-down CLIs

    Change If1e03c9343b8cc9c34bd51c2b4d25acdb21131ff in the API in Pike
    makes the os-services API look up services records via the host mapping
    in the API datadabase to determine which cell the service lives in.
    The host mappings only exist for nova-compute services, which means
    you can only enable/disable/force-down nova-compute services now, which
    is realistically the only service that ever made sense for those actions.

    That change broke some functional tests in novaclient though which loop
    through all services and disables them or forces them down. This change
    fixes those tests by only attempting the action on nova-compute services.

    This change also deprecates the binary argument to the service
    enable/disable/force-down commands since the only value that ever really
    worked or does anything is nova-compute, so a future version of the CLI
    should just hard-code that value.

    Change-Id: Idd0d2be960ca0ed59097c10c931da47a1a3e66fb
    Closes-Bug: #1700359