commit 09970fe366cf3200a53d93c41bc996a58a25a4af
Author: Matt Riedemann <email address hidden>
Date: Wed May 24 17:06:35 2017 -0400
Fix instance lookup in hide_server_addresses extension
The hide_server_addresses extension is looking up the cached
instance based on what the user provided for the server id,
which may not match what is used to cache the instance for the
request. For example, a request with upper-case server uuid
could be found in a mysql-backed system because mysql is
case insensitive by default, but the instance is keyed off the
server id from the DB, which is lower-case, so we'll fail
to look up the instance in the cache if the IDs don't match.
There is no test for this because it turns out it's actually
really hard to recreate this since it requires running with a
mysql backend to recreate the case insensitive check, which
isn't going to work with sqlite. Given how trivial this fix is,
creating a big mysql recreate test is not worth it.
Change-Id: I09b288aa2ad9969800a3cd26c675b002c6c9f638
Closes-Bug: #1693335
(cherry picked from commit ecfb65cee68e96cc99ceecddbf27c6d6f768358e)
Reviewed: https:/ /review. openstack. org/518997 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=09970fe366c f3200a53d93c41b c996a58a25a4af
Committed: https:/
Submitter: Zuul
Branch: stable/ocata
commit 09970fe366cf320 0a53d93c41bc996 a58a25a4af
Author: Matt Riedemann <email address hidden>
Date: Wed May 24 17:06:35 2017 -0400
Fix instance lookup in hide_server_ addresses extension
The hide_server_ addresses extension is looking up the cached
instance based on what the user provided for the server id,
which may not match what is used to cache the instance for the
request. For example, a request with upper-case server uuid
could be found in a mysql-backed system because mysql is
case insensitive by default, but the instance is keyed off the
server id from the DB, which is lower-case, so we'll fail
to look up the instance in the cache if the IDs don't match.
There is no test for this because it turns out it's actually
really hard to recreate this since it requires running with a
mysql backend to recreate the case insensitive check, which
isn't going to work with sqlite. Given how trivial this fix is,
creating a big mysql recreate test is not worth it.
Change-Id: I09b288aa2ad996 9800a3cd26c675b 002c6c9f638 c99ceecddbf27c6 d6f768358e)
Closes-Bug: #1693335
(cherry picked from commit ecfb65cee68e96c