commit de7c0594d19666bf20755dd0b8a040eb6a1217c0
Author: Matt Riedemann <email address hidden>
Date: Thu Mar 23 23:33:45 2017 +0000
Revert "libvirt: Pass instance to connect_volume and ..."
This reverts commit f0153fa4c87528e1dcbda8cba55d34ab7aec4e7a.
This broke a whole set of FS-based volume drivers since it
didn't change the method signatures in those drivers to take
the new instance argument.
I was working on adding them but then just decided this
isn't even used right now so it's faster to revert.
When this is added back in, I want to see the
LibvirtBaseVolumeDriver class turned into an ABC and
the connect_volume and disconnect_volume methods turned
into abstractmethods in LibvirtBaseVolumeDriver so this
kind of thing does not happen again.
Reviewed: https:/ /review. openstack. org/449362 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=de7c0594d19 666bf20755dd0b8 a040eb6a1217c0
Committed: https:/
Submitter: Jenkins
Branch: master
commit de7c0594d19666b f20755dd0b8a040 eb6a1217c0
Author: Matt Riedemann <email address hidden>
Date: Thu Mar 23 23:33:45 2017 +0000
Revert "libvirt: Pass instance to connect_volume and ..."
This reverts commit f0153fa4c87528e 1dcbda8cba55d34 ab7aec4e7a.
This broke a whole set of FS-based volume drivers since it
didn't change the method signatures in those drivers to take
the new instance argument.
I was working on adding them but then just decided this
isn't even used right now so it's faster to revert.
When this is added back in, I want to see the VolumeDriver class turned into an ABC and meDriver so this
LibvirtBase
the connect_volume and disconnect_volume methods turned
into abstractmethods in LibvirtBaseVolu
kind of thing does not happen again.
Change-Id: If1ee6d6e400475 0f80424ec54d7da bc564ec9e06
Closes-Bug: #1675584