The wrap_exception decorator optionally emited a notification.
Based on the code comments the original intention was not to include the
context to that notification due to security reasons. However the
implementation did included the context to the payload of the legacy
notification.
Recently we saw circural reference errors during the payload serialization
of this notification. Based on the logs the only complex data structure
that could cause circural reference is the context. So this patch
removes the context from the legacy exception notification.
The versioned exception notification is not affected as it does not
contain the args of the decorated function.
Reviewed: https:/ /review. openstack. org/446948 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=3bf177a59cf d0b4e74dba256c3 466ba2ea9bfbf7
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3bf177a59cfd0b4 e74dba256c3466b a2ea9bfbf7
Author: Balazs Gibizer <email address hidden>
Date: Fri Mar 17 11:24:49 2017 +0100
do not include context to exception notification
The wrap_exception decorator optionally emited a notification.
Based on the code comments the original intention was not to include the
context to that notification due to security reasons. However the
implementation did included the context to the payload of the legacy
notification.
Recently we saw circural reference errors during the payload serialization
of this notification. Based on the logs the only complex data structure
that could cause circural reference is the context. So this patch
removes the context from the legacy exception notification.
The versioned exception notification is not affected as it does not
contain the args of the decorated function.
Closes-Bug: #1673375 595a3e0e49ed57b 4ab33cd1688
Change-Id: I1d217620e52d45