Comment 34 for bug 1669054

Reviewed: https://review.opendev.org/649419
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=730e0e99d274a60f73e0892e9fc41dfb132d9a99
Submitter: Zuul
Branch: stable/ocata

commit 730e0e99d274a60f73e0892e9fc41dfb132d9a99
Author: Matt Riedemann <email address hidden>
Date: Sat Mar 23 12:01:42 2019 -0400

    Add functional regression test for bug 1669054

    Change Ic3968721d257a167f3f946e5387cd227a7eeec6c in Newton
    started setting the RequestSpec.ignore_hosts field to the
    source instance.host during resize/cold migrate if
    allow_resize_to_same_host=False in config, which it is by
    default.

    Change I8abdf58a6537dd5e15a012ea37a7b48abd726579 also in
    Newton persists changes to the RequestSpec in conductor
    in order to save the RequestSpec.flavor for the new flavor.
    This inadvertently persists the ignore_hosts field as well.

    Later if you try to evacuate or unshelve the server it will ignore
    the original source host because of the persisted ignore_hosts value.
    This is obviously a problem in a small deployment with only a few
    compute nodes (like an edge deployment). As a result, an evacuation
    can fail if the only available host is the one being ignored.

    This adds a functional regression recreate test for the bug.

    Conflicts:
          nova/tests/functional/api/client.py

    NOTE(mriedem): The conflict is due to not having change
    I71e9d8dae55653ad3ee70f708a6d92c98ed20c1c in Ocata which
    added the 201 value to the check_response_status default.

    NOTE(mriedem): This backport differs slightly in that
    (a) REQUIRES_LOCKING is removed and NeutronFixture is
    used explicitly since change I9b35ed7497db8bd1eb74f4bb89631aabbcfeec0d
    is not in Ocata and (b) kwargs are passed through post_server_action
    because change If7b02bcd8d77e94c7fb42b721792c1391bc0e3b7 is not in
    Ocata.

    Change-Id: I6ce2d6b1baf47796f867aede1acf292ec9739d6d
    Related-Bug: #1669054
    (cherry picked from commit 556cf103b22ab6bebecc9d824d6f918cda38fe3e)
    (cherry picked from commit 20c1414945db633ed00c1f19f1f0d163028454d9)
    (cherry picked from commit 77164128bf5eef53b49547658be2ef902c020207)
    (cherry picked from commit 9fd4082d7c076146ec314b86e0e4772d0a021712)
    (cherry picked from commit fcd718dcdd3cb7ba46f16ff97ecee068d55c8801)