commit 1848860fd4fb6dfb2ead1f8271050d36df592205
Author: Stephen Finucane <email address hidden>
Date: Wed Nov 2 12:43:35 2016 +0000
Ignore IOError when creating 'console.log'
In 'd4e6bd8', and later refined in 'ec6ed24c', an issue with the the
Quobyte CI was resolved by ensuring that the 'console.log' file is
always created, even when libvirt's 'dynamic_ownership' config option
is set to '0'. However, attempting to take ownership of this file can
cause issues when 'dynamic_ownership' is set to '1' and a user attempts
to reschedule an instance to a host where it was previously located. In
this case, the permissions on the file have already been co-opted by
libvirt, and attempting to change them results in an IOError.
The easiest fix for this is to simply ignore the IOError, as the file
already exists and libvirt has set correct permissions already. This is
what do here. A longer term fix would be to avoid changing the
permissions only for the offending Quobytes block devices, but this is
likely not backportable and will be done in a follow-up fix.
Reviewed: https:/ /review. openstack. org/392643 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=1848860fd4f b6dfb2ead1f8271 050d36df592205
Committed: https:/
Submitter: Jenkins
Branch: master
commit 1848860fd4fb6df b2ead1f8271050d 36df592205
Author: Stephen Finucane <email address hidden>
Date: Wed Nov 2 12:43:35 2016 +0000
Ignore IOError when creating 'console.log'
In 'd4e6bd8', and later refined in 'ec6ed24c', an issue with the the
Quobyte CI was resolved by ensuring that the 'console.log' file is
always created, even when libvirt's 'dynamic_ownership' config option
is set to '0'. However, attempting to take ownership of this file can
cause issues when 'dynamic_ownership' is set to '1' and a user attempts
to reschedule an instance to a host where it was previously located. In
this case, the permissions on the file have already been co-opted by
libvirt, and attempting to change them results in an IOError.
The easiest fix for this is to simply ignore the IOError, as the file
already exists and libvirt has set correct permissions already. This is
what do here. A longer term fix would be to avoid changing the
permissions only for the offending Quobytes block devices, but this is
likely not backportable and will be done in a follow-up fix.
Change-Id: I353afd57be2073 30757580447a1b6 06c7b9b7c09
Partial-bug: #1634282
Related-bug: #1597644
Related-bug: #1609298