Comment 3 for bug 1605720

Revision history for this message
Thiago Martins (martinx) wrote :

I'm trying to include the patch:

https://review.openstack.org/changes/346263/revisions/d7b831e38cbc029b7975d1059ed212762a5f6a5e/patch?zip

...on top of Ubuntu Xenial packages but, it fails here:

---
apt source nova
cd nova-13.1.1

nova-13.1.1$ patch -p1 < ../d7b831e3.diff
patching file nova/tests/unit/virt/libvirt/fake_imagebackend.py
Hunk #1 FAILED at 138.
1 out of 1 hunk FAILED -- saving rejects to file nova/tests/unit/virt/libvirt/fake_imagebackend.py.rej
patching file nova/tests/unit/virt/libvirt/test_driver.py
Hunk #1 succeeded at 17 (offset -2 lines).
Hunk #2 succeeded at 9549 (offset -975 lines).
Hunk #3 succeeded at 9574 with fuzz 2 (offset -980 lines).
Hunk #4 succeeded at 9674 (offset -969 lines).
Hunk #5 succeeded at 14565 (offset -1092 lines).
Hunk #6 succeeded at 14579 (offset -1092 lines).
Hunk #7 succeeded at 14647 with fuzz 2 (offset -1095 lines).
patching file nova/virt/libvirt/driver.py
Hunk #1 succeeded at 3112 (offset 152 lines).
Hunk #2 succeeded at 3238 (offset 185 lines).
Hunk #3 succeeded at 7397 with fuzz 1 (offset 191 lines).
---

 We need a proper fix for this on Ubuntu! :-P

 I'll try to rebuild the package with this patch but, don't know yet if tests will pass... If not, is there any way to disable the tests during package creation?

Cheers!
Thiago