Comment 41 for bug 1550919

Reviewed: https://review.opendev.org/732708
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ae7602c1206de23439d6c3609b5872831138aa99
Submitter: Zuul
Branch: stable/rocky

commit ae7602c1206de23439d6c3609b5872831138aa99
Author: Matthew Booth <email address hidden>
Date: Wed Aug 15 14:39:48 2018 +0100

    libvirt: Don't delete disks on shared storage during evacuate

    When evacuating an instance between compute hosts on shared storage,
    during the rebuild operation we call spawn() on the destination
    compute. spawn() currently assumes that it should cleanup all
    resources on failure, which results in user data being deleted in the
    evacuate case.

    This change modifies spawn in the libvirt driver such that it only
    cleans up resources it created.

    Conflicts:
        nova/tests/functional/libvirt/test_pci_sriov_servers.py

    NOTE(stephenfin): Conflicts due to
    Id4d8ecb8fee46b21590ebcc62a2850030cef6508 ("objects: Store
    InstancePCIRequest.numa_policy in DB") not being present on
    stable/rocky.

    Co-Authored-By: Lee Yarwood <email address hidden>
    Closes-Bug: #1550919
    Change-Id: I764481966c96a67d993da6e902dc9fc3ad29ee36
    (cherry picked from commit 497360b0ea970f1e68912be8229ef8c3f5454e9e)
    (cherry picked from commit 8b48ca672d9c0eb108c71b7f9f3f089d9ecf688a)
    (cherry picked from commit 1a320f2a0e0918de6afcce5cf23b7de178ec3a49)
    (cherry picked from commit a7d8aa699793e1d60ece4e03920e6041337f9a43)