Comment 40 for bug 1550919

Reviewed: https://review.opendev.org/732707
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6118101cbae56e80a22a35a5ffcb07a0ed259b99
Submitter: Zuul
Branch: stable/rocky

commit 6118101cbae56e80a22a35a5ffcb07a0ed259b99
Author: Matthew Booth <email address hidden>
Date: Tue Aug 14 16:05:11 2018 +0100

    Add functional test for bug 1550919

    This adds a failing test, which we fix in change I76448196.

    An earlier version of this change was previously merged as
    change I5619728d. This was later reverted, as it was failing in the
    gate. However, on inspection these failures seem to have been simply
    timeouts due to load.

    Changes from previous version:

    - Increase the timeouts which were previously triggering, and
      serialise server creation to reduce the chance of this recurring.
    - Add an LVM test, which highlights the requirement to flag the
      creation of ephemeral and swap disks.
    - Add an Qcow2 test, essentially the same as the Flat test but ensures
      coverage of the most common backends.
    - Each test now uses a separate instances_path allowing for cleanup
      without racing against other active tests.
    - Some nits addressed.

    For the time being this test does not make use of the recently improved
    nova.tests.functional.libvirt.base.ServersTestBase class to ease
    backports. Future changes should be made to use this class removing some
    of the common setUp logic from _LibvirtEvacuateTest.

    NOTE(lyarwood): The following changes are required for stable/rocky:

    * uuidsentinel is imported from nova.tests as we don't have access to
      oslo.utils 3.37.0 that introduced uuidsentinel as used by
      I7f5f08691ca3f73073c66c29dddb996fb2c2b266 in openstack/nova during
      stable/stein.

    * Use nova.tests.fixtures.PlacementFixture due to
      Idaed39629095f86d24a54334c699a26c218c6593 not being present in
      stable/rocky.

    Co-Authored-By: Lee Yarwood <email address hidden>
    Related-Bug: #1550919
    Change-Id: I1062b3e74382734edbb2142a09ff0073c66af8db
    (cherry picked from commit 90e0e874bde38937380d09ab27a7defbb5475cc2)
    (cherry picked from commit 6ccd13f8aeeb97c2139c1abc93cb976fd57d57dd)
    (cherry picked from commit 172eb21dee1d93b140c2b691cb8dfbc68b721bfe)
    (cherry picked from commit d7a1cb57247c4b1faa09b9c81c5cd2fbd4639095)