commit 116b1210ab772c55d1ed1f715687d83877c92701
Author: Lee Yarwood <email address hidden>
Date: Wed Feb 24 11:23:22 2016 +0000
libvirt: Always copy or recreate disk.info during a migration
The disk.info file contains the path and format of any image, config or
ephermal disk associated with an instance. When using RAW images and migrating
an instance this file should always be copied or recreated. This avoids the Raw
imagebackend reinspecting the format of these disks when spawning the instance
on the destination host.
By not copying or recreating this disk.info file, a malicious image written to
an instance disk on the source host will cause Nova to reinspect and record a
different format for the disk on the destination. This format then being used
incorrectly when finally spawning the instance on the destination.
Reviewed: https:/ /review. openstack. org/289957 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=116b1210ab7 72c55d1ed1f7156 87d83877c92701
Committed: https:/
Submitter: Jenkins
Branch: master
commit 116b1210ab772c5 5d1ed1f715687d8 3877c92701
Author: Lee Yarwood <email address hidden>
Date: Wed Feb 24 11:23:22 2016 +0000
libvirt: Always copy or recreate disk.info during a migration
The disk.info file contains the path and format of any image, config or
ephermal disk associated with an instance. When using RAW images and migrating
an instance this file should always be copied or recreated. This avoids the Raw
imagebackend reinspecting the format of these disks when spawning the instance
on the destination host.
By not copying or recreating this disk.info file, a malicious image written to
an instance disk on the source host will cause Nova to reinspect and record a
different format for the disk on the destination. This format then being used
incorrectly when finally spawning the instance on the destination.
SecurityImpact ab31ac1c1d8d79a 129acc9fb87
Closes-bug: #1548450
Change-Id: Idfc16f54049aae