nova-scheduler also loads deleted instances at startup

[Belmiro Moreira]

nova-scheduler is loading all instances (including deleted) at startup.

Experienced problems when each node has >6000 deleted instances, even when using batches of 10 nodes.
Each query can take several minutes and transfer several GB of data.
This prevented nova-scheduler connect to rabbitmq.

###
When nova-scheduler starts it calls "_async_init_instance_info()" and it does an "InstanceList.get_by_filters" that uses batches of 10 nodes. This uses "instance_get_all_by_filters_sort", however "Deleted instances will be returned by default, unless there's a filter that says otherwise".
Adding the filter: {"deleted": False} fixes the problem.

[Tardis Xu (xiaoxubeii)]

Hi Belmiro Moreira,

I can reproduce your bug, and the nova-scheduler filters all the instances indeed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/255178

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tardis Xu (<email address hidden>) on branch: master
Review: https://review.openstack.org/255178
Reason: wrong code

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/255178
Reason: Abandoning this, because the other fix is the one we want to go with.