Host Manager reads deleted instance info on startup

[Ed Leafe]

In Kilo we added the ability of the HostManager to track information about the instances on compute nodes, so that filters that needed this information didn't have to constantly make database calls to get it. However, the call that is used by HostManager will return deleted instance records, which is not useful information and degrades the performance. In a large deployment, the overhead of loading the records for thousands of deleted instances is causing serious performance issues.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/255405

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/255405
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3d6fac8dea940b62e88f239c5615acc500b74f05
Submitter: Jenkins
Branch: master

commit 3d6fac8dea940b62e88f239c5615acc500b74f05
Author: EdLeafe <email address hidden>
Date: Wed Dec 9 17:51:52 2015 +0000

    Don't load deleted instances

    When the HostManager starts up, it loads the instance information for
    all of the compute nodes. The call it uses, though, includes the records
    for deleted instances, which are not needed, and which can cause
    performance issues for large deployments. This patch adds a filter on
    deleted records.

    Closes-bug: 1524421

    Change-Id: I404b6baa5504316f447d9c504132183198ff689e

[Matt Riedemann (mriedem)]

This was mentioned in CERNs blog on upgrading to kilo so marking as medium and marking for backport to liberty and kilo:

http://openstack-in-production.blogspot.com/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/264794

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/264795

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/264794
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7c1f1af2e23494e3424cfc105509fd2f168e06ca
Submitter: Jenkins
Branch: stable/liberty

commit 7c1f1af2e23494e3424cfc105509fd2f168e06ca
Author: EdLeafe <email address hidden>
Date: Wed Dec 9 17:51:52 2015 +0000

    Don't load deleted instances

    When the HostManager starts up, it loads the instance information for
    all of the compute nodes. The call it uses, though, includes the records
    for deleted instances, which are not needed, and which can cause
    performance issues for large deployments. This patch adds a filter on
    deleted records.

    Closes-bug: 1524421

    Change-Id: I404b6baa5504316f447d9c504132183198ff689e
    (cherry picked from commit 3d6fac8dea940b62e88f239c5615acc500b74f05)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/264795
Reason: Yeah let's just drop this, it's not critical.