Comment 4 for bug 1508230

Reviewed: https://review.openstack.org/237799
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=835ff1bf73d36a311168283f8a4ef5bec03d5a7e
Submitter: Jenkins
Branch: master

commit 835ff1bf73d36a311168283f8a4ef5bec03d5a7e
Author: Sam Yaple <email address hidden>
Date: Tue Oct 20 22:42:36 2015 +0000

    Fix attibute error when cloning raw images in Ceph

    A regression introduced in If03b166d3ecc3e7fa6b7f1a0c69f8ab1cc7b1972
    causes a glance image with the type 'raw' in ceph to fail to CoW
    clone which prevents launching at all in this case.

    The original patch did not update imagebackend.py [1] to use the new
    nova.objects.ImageMeta object so the clone() function passes a normal
    dict to the is_cloneable() function.

    Additionally add another test to ensure that not passing disk_format
    will fail, but not result in an exception. It will simply mean that
    the function returns that it cannot take advantage of the CoW cloning
    ceph provides.

    [1] https://github.com/openstack/nova/blob/f2e2a5891d5f5ff9346e6dc8e4dd0e994485245c/nova/virt/libvirt/imagebackend.py#L824

    Change-Id: I7ae107bfccab7ff66c09d96856722dd6e60fdd96
    Closes-Bug: #1508230