Comment 4 for bug 1494653

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/kilo)

Reviewed: https://review.openstack.org/223968
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2e731ebc9dd4890b6bfa57ceaaa6dadba2e4b1c2
Submitter: Jenkins
Branch: stable/kilo

commit 2e731ebc9dd4890b6bfa57ceaaa6dadba2e4b1c2
Author: Rajesh Tailor <email address hidden>
Date: Thu Sep 10 23:15:46 2015 -0700

    Remove unnecessary 'context' param from quotas reserve method call

    'context' parameter was removed from quota-related method signatures in patch [1].
    In patch [2] use of 'context' parameter was removed from quota-related method calls.

    Still at some places 'context' parameter was passed to quota reserve method call.

    Removed use of 'context' parameter from those places and passed 'context' as kwargs
    while creating object of nova.objects.Quotas type.

    [1] https://review.openstack.org/#/c/164268/
    [2] https://review.openstack.org/#/c/160499/

    Backport notice:
    On restart of nova-compute if there is instance with vm_state as
    'DELETED' but that instance is not marked as deleted in database. In that case,
    while calling _complete_partial_deletion method from _init_instance method
    it raises " ValueError: Circular reference detected" error.

    Removing 'context' parameter from quotas.reserve method call in
    _complete_partial_deletion method addresses this issue as well.

    Change-Id: I20ea77bd20f093ce1be7169c0647cdc7ff62117c
    Closes-Bug: 1494653
    (cherry picked from commit 4031272fe93d1046cff4c0cc788c8e78db944419)