Comment 1 for bug 1493980

Revision history for this message
Matt Riedemann (mriedem) wrote :

To test this, I made a change like this:

                        LOG.debug('Explicitly disassociating fixed IP %(test)s from '
                                  'instance.', address,
                                  instance_uuid=instance_uuid)

And then ran a unit test that I know hits that code and it failed:

nova.tests.unit.network.test_manager.NetworkManagerNoDBTestCase.test_deallocate_fixed_ip_explicit_disassociate
--------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "/home/mriedem/git/nova/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
        return func(*args, **keywargs)
      File "nova/tests/unit/network/test_manager.py", line 3643, in test_deallocate_fixed_ip_explicit_disassociate
        do_test()
      File "/home/mriedem/git/nova/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
        return func(*args, **keywargs)
      File "nova/tests/unit/network/test_manager.py", line 3635, in do_test
        self.context, fip['address'], instance=fake_inst)
      File "nova/network/manager.py", line 1090, in deallocate_fixed_ip
        instance=instance)
      File "/home/mriedem/git/nova/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 195, in __exit__
        six.reraise(self.type_, self.value, self.tb)
      File "nova/network/manager.py", line 1078, in deallocate_fixed_ip
        instance_uuid=instance_uuid)
      File "/usr/lib/python2.7/logging/__init__.py", line 1425, in debug
        self.logger.debug(msg, *args, **kwargs)
      File "/usr/lib/python2.7/logging/__init__.py", line 1140, in debug
        self._log(DEBUG, msg, args, **kwargs)
      File "/usr/lib/python2.7/logging/__init__.py", line 1271, in _log
        self.handle(record)
      File "/usr/lib/python2.7/logging/__init__.py", line 1281, in handle
        self.callHandlers(record)
      File "/usr/lib/python2.7/logging/__init__.py", line 1321, in callHandlers
        hdlr.handle(record)
      File "nova/tests/fixtures.py", line 69, in handle
        self.format(record)
      File "/usr/lib/python2.7/logging/__init__.py", line 724, in format
        return fmt.format(record)
      File "/usr/lib/python2.7/logging/__init__.py", line 464, in format
        record.message = record.getMessage()
      File "/usr/lib/python2.7/logging/__init__.py", line 328, in getMessage
        msg = msg % self.args
    TypeError: format requires a mapping