Conductor has 2 approaches to hande rpc api calls:
- in place (code located in manager itself)
- in tasks (for each operation creates new task class
where all logic is located)
Second approach allows to implement single responsibility
to each method.
In this patch, a class hierarchy for tasks is introduced.
It allows share same public interface between tasks.
Cold-migration/resize logic is also moved to its
new task class. This change simplifies unit tests,
by making them cleaner.
Reviewed: https:/ /review. openstack. org/184495 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=83787211b3e a2734e62edc746d 42ecfa72fb0386
Committed: https:/
Submitter: Jenkins
Branch: master
commit 83787211b3ea273 4e62edc746d42ec fa72fb0386
Author: Timofey Durakov <email address hidden>
Date: Wed Jun 24 13:05:06 2015 +0300
Create class hierarchy for tasks in conductor
Conductor has 2 approaches to hande rpc api calls:
- in place (code located in manager itself)
- in tasks (for each operation creates new task class
where all logic is located)
Second approach allows to implement single responsibility
to each method.
In this patch, a class hierarchy for tasks is introduced. migration/ resize logic is also moved to its
It allows share same public interface between tasks.
Cold-
new task class. This change simplifies unit tests,
by making them cleaner.
Closes-Bug: #1468696
Change-Id: I820c4a8ccc58e1 40f24597a52f2e0 1444cd6d134