commit c943cbbc40654827f537773a90d77577a54dbe0b
Author: Sean Dague <email address hidden>
Date: Thu Mar 12 16:55:55 2015 -0400
ensure DatabaseFixture removes db on cleanup
The DatabaseFixture was previously just ensuring that tests which used
it had a clean database when they started. It did not ensure there was
no working database around when it wasn't being used, so tests which
leaked into the database might pass even if they were listed as a
NoDBTest, because there was an in memory test db from a prior run.
This adds a cleanup path to the fixture which blows away the db at the
end of the test (which itself is tested). There were 46 tests which
failed when we got this isolation correct, and this changes all those
test classes containing those tests to require a db. Many of these
could have narrower fixes, but this returns us to an isolated state.
Reviewed: https:/ /review. openstack. org/163970 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=c943cbbc406 54827f537773a90 d77577a54dbe0b
Committed: https:/
Submitter: Jenkins
Branch: master
commit c943cbbc4065482 7f537773a90d775 77a54dbe0b
Author: Sean Dague <email address hidden>
Date: Thu Mar 12 16:55:55 2015 -0400
ensure DatabaseFixture removes db on cleanup
The DatabaseFixture was previously just ensuring that tests which used
it had a clean database when they started. It did not ensure there was
no working database around when it wasn't being used, so tests which
leaked into the database might pass even if they were listed as a
NoDBTest, because there was an in memory test db from a prior run.
This adds a cleanup path to the fixture which blows away the db at the
end of the test (which itself is tested). There were 46 tests which
failed when we got this isolation correct, and this changes all those
test classes containing those tests to require a db. Many of these
could have narrower fixes, but this returns us to an isolated state.
Change-Id: Id0480035d8e615 ae602da9737cd2c 94bc7967067
Closes-Bug: #1431519
Closes-Bug: #1431551