OpenStack Compute (nova)

  1. Bug #1409142
  2. Comment #45

Comment 45 for bug 1409142

Revision history for this message
Dave McCowan (dave-mccowan) wrote : Re: Websocket Hijacking Vulnerability in Nova VNC Server (CVE-2015-0259)

I may have been over thinking it. Perhaps there is a fix that also checks the protocol in a clean way. Nova API builds the 'access_url' that includes the proto (http or https). The Origin header in the websocket handshake includes the used proto (http or https). These two need to match. websocketproxy.py has easy access to the latter. @nova-experts: any suggestions on how to pull 'access_url' from Nova API into NoVNC?

If they do match then I believe we have a complete solution. @Paul?