VMware: resized instance not marked as 'belonging' to OpenStack

Bug #1402784 reported by Gary Kotton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Gary Kotton

Bug Description

Commit f4fec08e9850dae163f447e72cd1c7f638b2bb10 added support for 'belonging' to OpenStack. The resize was not treated

Tags: vmware
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141874

Changed in nova:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Gary Kotton (garyk)
Changed in nova:
importance: Undecided → Medium
tags: added: vmware
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by garyk (<email address hidden>) on branch: master
Review: https://review.openstack.org/141874
Reason: This is no longer required - https://review.openstack.org/#/c/145007 addresses this issue

Revision history for this message
Gary Kotton (garyk) wrote :

This is actually addressed in https://review.openstack.org/#/c/145007

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Fix proposed is in progress - https://review.openstack.org/#/c/145007

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/145007
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f3f1a53fe2bfe23229867c4a90f6456ac204181f
Submitter: Jenkins
Branch: master

commit f3f1a53fe2bfe23229867c4a90f6456ac204181f
Author: Gary Kotton <email address hidden>
Date: Mon Jan 5 02:48:15 2015 -0800

    VMware: address instance resize problems

    The resize code in the driver is problematic. This stems
    from the fact that a clone of the VM takes place. There are
    a number of know issues with this:
    1. resize selects an invalid datastore (bug 1407438)
    2. resize may fail when a selected host does not have access
       to the datastore that has the config driver file (bug
       1407050)
    3. resized instances are not marked as owned by OpenStack on the
       VC (bug 1402784)

    In fact we could do the resize on the existing VM. This has the
    following advantages:
    1. it does not need an additional VM
    2. it fixes the bugs that are mentioned above
    3. It is now far simpler and more robust
    4. It does not require convoluted instance naming and tracking
    5. VM deletion is simple
    6. enables better test covergae

    The patch makes use of the same VM for resizing.

    Methods no longer used have been removed. These methods were
    specific to the old resize.

    Co-authored-by: Radoslav Gerganov <email address hidden>

    Change-Id: Ibcb108c2e0f84a84c599d2e7762a11efc7659395
    Closes-bug: #1407438
    Closes-bug: #1407050
    Closes-bug: #1402784

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.