VMware: resize may select wrong datastore

[Gary Kotton]

When resizing a root disk the first datastore is selected. This may not be the datastore that has the root disk. We need the root disk datstore

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/144888

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145007

[OpenStack Infra (hudson-openstack)]

Change abandoned by garyk (<email address hidden>) on branch: master
Review: https://review.openstack.org/144888
Reason: Replaced by https://review.openstack.org/145007

[Davanum Srinivas (DIMS) (dims-v)]

Fix proposed is in progress - https://review.openstack.org/#/c/145007/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145007
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f3f1a53fe2bfe23229867c4a90f6456ac204181f
Submitter: Jenkins
Branch: master

commit f3f1a53fe2bfe23229867c4a90f6456ac204181f
Author: Gary Kotton <email address hidden>
Date: Mon Jan 5 02:48:15 2015 -0800

    VMware: address instance resize problems

    The resize code in the driver is problematic. This stems
    from the fact that a clone of the VM takes place. There are
    a number of know issues with this:
    1. resize selects an invalid datastore (bug 1407438)
    2. resize may fail when a selected host does not have access
       to the datastore that has the config driver file (bug
       1407050)
    3. resized instances are not marked as owned by OpenStack on the
       VC (bug 1402784)

    In fact we could do the resize on the existing VM. This has the
    following advantages:
    1. it does not need an additional VM
    2. it fixes the bugs that are mentioned above
    3. It is now far simpler and more robust
    4. It does not require convoluted instance naming and tracking
    5. VM deletion is simple
    6. enables better test covergae

    The patch makes use of the same VM for resizing.

    Methods no longer used have been removed. These methods were
    specific to the old resize.

    Co-authored-by: Radoslav Gerganov <email address hidden>

    Change-Id: Ibcb108c2e0f84a84c599d2e7762a11efc7659395
    Closes-bug: #1407438
    Closes-bug: #1407050
    Closes-bug: #1402784