commit c8538208da00c3b0d0646629c9d668aa69944b85
Author: Russell Bryant <email address hidden>
Date: Wed Oct 8 12:14:31 2014 +0000
Fix broken cert revocation
Cert revocation was broken by
32b0adb591f80ad2c5c19519b4ffc2b55dbea672. os.chdir() never returns
anything, so this method would always raise an exception. The proper
way to handle an error from os.chdir() is to catch OSError.
There were existing tests for this code, but they conveniently mocked
os.chdir() to return values that are never actually returned. The
tests were fixed to match the real behavior.
Reviewed: https:/ /review. openstack. org/126890 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=c8538208da0 0c3b0d0646629c9 d668aa69944b85
Committed: https:/
Submitter: Jenkins
Branch: master
commit c8538208da00c3b 0d0646629c9d668 aa69944b85
Author: Russell Bryant <email address hidden>
Date: Wed Oct 8 12:14:31 2014 +0000
Fix broken cert revocation
Cert revocation was broken by 80ad2c5c19519b4 ffc2b55dbea672. os.chdir() never returns
32b0adb591f
anything, so this method would always raise an exception. The proper
way to handle an error from os.chdir() is to catch OSError.
There were existing tests for this code, but they conveniently mocked
os.chdir() to return values that are never actually returned. The
tests were fixed to match the real behavior.
Change-Id: I7549bb60a7d43d 53d6f81eecea31c bb9720cc8b6
Closes-bug: #1376368