commit f78165661e5ce0bd7287124b75f6c60845b9a3c1
Author: Roman Podoliaka <email address hidden>
Date: Tue Aug 19 14:05:50 2014 +0300
Add _security_group_ensure_default() DBAPI method
According to the convention we use for DB API methods, every public
method should have a private counterpart. The difference between
those two is that the latter accepts an optional 'session' argument,
which makes it possible for the method to participate in the existing
database transaction.
security_group_ensure_default() was called inside instance_create()
and thus implicitly created a new concurrent db transaction, which
is now fixed by making a call to a private counterpart and passing
the session instance.
Closes-Bug: #1362233
Change-Id: Ifa1b6430328fde1ab0984f726bd8392bbd3f7ee5
(cherry picked from commit dbc46b99cc85402c087bb214c120bce2c65dfea9)
Reviewed: https:/ /review. openstack. org/134928 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=f78165661e5 ce0bd7287124b75 f6c60845b9a3c1
Committed: https:/
Submitter: Jenkins
Branch: stable/icehouse
commit f78165661e5ce0b d7287124b75f6c6 0845b9a3c1
Author: Roman Podoliaka <email address hidden>
Date: Tue Aug 19 14:05:50 2014 +0300
Add _security_ group_ensure_ default( ) DBAPI method
According to the convention we use for DB API methods, every public
method should have a private counterpart. The difference between
those two is that the latter accepts an optional 'session' argument,
which makes it possible for the method to participate in the existing
database transaction.
security_ group_ensure_ default( ) was called inside instance_create()
and thus implicitly created a new concurrent db transaction, which
is now fixed by making a call to a private counterpart and passing
the session instance.
Closes-Bug: #1362233
Change-Id: Ifa1b6430328fde 1ab0984f726bd83 92bbd3f7ee5 c087bb214c120bc e2c65dfea9)
(cherry picked from commit dbc46b99cc85402