Comment 4 for bug 1357578

Revision history for this message
Jay Pipes (jaypipes) wrote :

Matt, I think the eventlet.Timeout thing is a red herring. fixtures.Timeout uses the signal module from the standard Python library to interrupt the process after timeout_secs. It does not use eventlet.Timeout. That said, there are two places I found that are incorrectly using eventlet.timeout.Timeout() without a context manager or calling close():

jaypipes@cranky:~/repos/openstack/nova/nova$ ack-grep "Timeout\("
tests/virt/libvirt/test_driver.py
8925: raise eventlet.timeout.Timeout()

tests/virt/hyperv/test_vmops.py
196: mock_with_timeout.side_effect = etimeout.Timeout()