Comment 4 for bug 1348629

Reviewed: https://review.openstack.org/109594
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8fcd1b2c73dad8e2a7b4d299da270934fd5328cc
Submitter: Jenkins
Branch: master

commit 8fcd1b2c73dad8e2a7b4d299da270934fd5328cc
Author: Daniel P. Berrange <email address hidden>
Date: Fri Jul 25 12:55:40 2014 +0100

    virt: use compute.vm_mode constants and validate vm mode type

    Where we have hardcoded vm modes, use compute.vm_mode constants.
    Where we get vm modes from external systems, validate them against
    the list of acceptable names.

    The baremetal/ironic drivers are reporting a bogus vm mode of
    'baremetal' for supported instances which is confusing the vm
    mode with the Nova driver type. These drivers use the native
    ABI for their architecture, so should be reporting 'hvm' as
    the vm mode, which indicates an unmodified native OS ABI.

    On the other side, the ImagePropertiesFilter will canonicalize
    the hvtype it fetches from image metadata, so that 'baremetal'
    gets remapped to 'hvm' during comparison.

    Closes-bug: #1348629
    Change-Id: Ibda7c5ab0759aee672870d84974ccdea25f14407