There is wrong assert method in
nova.tests.virt.vmwareapi.vmwareapi.test_vmops.py:640
while checking a number of calls mocked method 'mkdir'.
We should use assertEqual(3, len(mock_mkdir.mock_calls))
instead of self.assertTrue(3, len(mock_mkdir.mock_calls))
But number of calling method 'mkdir' not always is 3.
If dict block_device_info contains key 'block_device_mapping'
with any information, method 'mkdir' wouldn't be called in method
self._vmops.spawn(). That is why corresponding check been added.
Reviewed: https:/ /review. openstack. org/103550 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=aaa9d6a8a28 335b8dac4e1d404 5571aa565e3196
Committed: https:/
Submitter: Jenkins
Branch: master
commit aaa9d6a8a28335b 8dac4e1d4045571 aa565e3196
Author: Sergey Nikitin <email address hidden>
Date: Mon Jun 30 17:55:46 2014 +0400
Fixed wrong assertion in test_vmops.py
There is wrong assert method in tests.virt. vmwareapi. vmwareapi. test_vmops. py:640
nova.
while checking a number of calls mocked method 'mkdir'.
We should use assertEqual(3, len(mock_ mkdir.mock_ calls)) mkdir.mock_ calls))
instead of self.assertTrue(3, len(mock_
But number of calling method 'mkdir' not always is 3. device_ mapping' _vmops. spawn() . That is why corresponding check been added.
If dict block_device_info contains key 'block_
with any information, method 'mkdir' wouldn't be called in method
self.
Change-Id: Ifc26e112b9c297 4e0fb7a91ba39d5 b2d887bd549
Closes-Bug: #1335859