commit 2f40191d0efa783ca879338578097548ee8c84c0
Author: Joe Gordon <email address hidden>
Date: Thu Jun 12 16:27:07 2014 -0700
Failure during termination should always leave state as error()
Currently we have a situation where if an instance fails to delete,
instead of having its state reverted, like we do in most places we set
it to error,deleting. This was intentionally done in
I5fb1bbd56035792f566a6e076edfe7a69df006ef. We also intentionally ignore
duplicate requests to delete an instance if its already being deleted
(I2f97f93bd714e0ea3b6d4fa3ac457ab43eed00e1). The combination of these two
things means that if an instance fails to delete for some reason a
tenant is unable to delete that instance.
It turns out this is really bad because instances in deleting state
count against quota, so the tenant slowly looses usable quota.
To fix this, upon a failed termination set the vm_state to error and
revert the task_state. This is a partial revert of
I55742203bdd071c7df90902868e46c2020f799bd.
Change-Id: I55742203bdd071c7df90902868e46c2020f799bd
Closes-Bug: #1329559
(cherry picked from commit f33a25a3c40722644c774395b38fd7a7ed0246e1)
Reviewed: https:/ /review. openstack. org/100469 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=2f40191d0ef a783ca879338578 097548ee8c84c0
Committed: https:/
Submitter: Jenkins
Branch: stable/icehouse
commit 2f40191d0efa783 ca8793385780975 48ee8c84c0
Author: Joe Gordon <email address hidden>
Date: Thu Jun 12 16:27:07 2014 -0700
Failure during termination should always leave state as error()
Currently we have a situation where if an instance fails to delete, 35792f566a6e076 edfe7a69df006ef . We also intentionally ignore 714e0ea3b6d4fa3 ac457ab43eed00e 1). The combination of these two
instead of having its state reverted, like we do in most places we set
it to error,deleting. This was intentionally done in
I5fb1bbd560
duplicate requests to delete an instance if its already being deleted
(I2f97f93bd
things means that if an instance fails to delete for some reason a
tenant is unable to delete that instance.
It turns out this is really bad because instances in deleting state
count against quota, so the tenant slowly looses usable quota.
To fix this, upon a failed termination set the vm_state to error and d071c7df9090286 8e46c2020f799bd .
revert the task_state. This is a partial revert of
I55742203bd
Change-Id: I55742203bdd071 c7df90902868e46 c2020f799bd 44c774395b38fd7 a7ed0246e1)
Closes-Bug: #1329559
(cherry picked from commit f33a25a3c407226