commit e4e1c6a2f060a91899549b9643132abde27d033e
Author: Matt Riedemann <email address hidden>
Date: Thu Mar 5 14:44:00 2015 -0800
libvirt: add comment for vifs_already_plugged=True in finish_migration
Given we unplug VIFs in _cleanup_resize if the host has changed, it's
confusing to pass vifs_already_plugged=True in finish_migration without
some explanation of why we don't check to see if the host has changed
before deciding what the value of vifs_already_plugged should be when
creating the new domain and plugging VIFs again.
After some discussion with Neutron cores, this is the explanation I've
come up with, albeit not a great one, and indicates a gap in some of the
nova/neutron integration story.
Reviewed: https:/ /review. openstack. org/161934 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=e4e1c6a2f06 0a91899549b9643 132abde27d033e
Committed: https:/
Submitter: Jenkins
Branch: master
commit e4e1c6a2f060a91 899549b9643132a bde27d033e
Author: Matt Riedemann <email address hidden>
Date: Thu Mar 5 14:44:00 2015 -0800
libvirt: add comment for vifs_already_ plugged= True in finish_migration
Given we unplug VIFs in _cleanup_resize if the host has changed, it's plugged= True in finish_migration without plugged should be when
confusing to pass vifs_already_
some explanation of why we don't check to see if the host has changed
before deciding what the value of vifs_already_
creating the new domain and plugging VIFs again.
After some discussion with Neutron cores, this is the explanation I've
come up with, albeit not a great one, and indicates a gap in some of the
nova/neutron integration story.
Related-Bug: #1323658
Change-Id: I982b6bd0650f29 f34c213b6eebbe0 66f7bd65815