commit db50aaca0acdf7814a8d6673545db94738907131
Author: Matt Riedemann <email address hidden>
Date: Sat Mar 5 13:40:52 2016 -0500
Use SensitiveStringField for BlockDeviceMapping.connection_info
bd977f400a1192d5cf7c2b52ef91615c0828813c added the SensitiveStringField
to oslo.versionedobjects. SensitiveStringField is a StringField, which
is what BlockDeviceMapping.connection_info was already using. The difference
is that a SensitiveStringField masks passwords in the 'stringify' method,
which is what's used when __repr__ is called on the object.
Since BDM.connection_info can contain credentials, and the connection_info
dict gets passed around quite a bit in the compute manager and virt drivers,
it has from time to time gotten logged without first masking passwords.
This makes the object handle masking the password so we don't have to do it
explicitly anymore.
There is no version bump on the BlockDeviceMapping object since nothing has
functionally changed.
Reviewed: https:/ /review. openstack. org/288927 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=db50aaca0ac df7814a8d667354 5db94738907131
Committed: https:/
Submitter: Jenkins
Branch: master
commit db50aaca0acdf78 14a8d6673545db9 4738907131
Author: Matt Riedemann <email address hidden>
Date: Sat Mar 5 13:40:52 2016 -0500
Use SensitiveString Field for BlockDeviceMapp ing.connection_ info
bd977f400a1 192d5cf7c2b52ef 91615c0828813c added the SensitiveString Field bjects. SensitiveString Field is a StringField, which ing.connection_ info was already using. The difference Field masks passwords in the 'stringify' method,
to oslo.versionedo
is what BlockDeviceMapp
is that a SensitiveString
which is what's used when __repr__ is called on the object.
Since BDM.connection_info can contain credentials, and the connection_info
dict gets passed around quite a bit in the compute manager and virt drivers,
it has from time to time gotten logged without first masking passwords.
This makes the object handle masking the password so we don't have to do it
explicitly anymore.
There is no version bump on the BlockDeviceMapping object since nothing has
functionally changed.
Change-Id: I66a0b5f6834034 e2fcbefc4510e3a a018edec310
Closes-Bug: #1321785