Comment 5 for bug 1319180

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/93842
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=de92d65f2981b826e145e82ab2734c19bf1dffa3
Submitter: Jenkins
Branch: master

commit de92d65f2981b826e145e82ab2734c19bf1dffa3
Author: Davanum Srinivas <email address hidden>
Date: Thu May 15 23:22:05 2014 -0400

    Test force_config_drive as a boolean as last resort

    The force_config_drive help clearly states that only possible option is
    'always' but folks are setting it to 'True'/'False' etc and expecting
    it to work. So let's enable that as well. In the worst case scenario
    mentioned in the bug, it was set to 'False' and since the check for
    force_config_drive took any string as true, we were enabling the flag
    to true. With the change in this review, we force a conversion of the
    string to true. Additional check for the flag to be set as 'always' is
    treated as true as well. The test case checks for all the variations

    Closes-Bug: #1319180
    DocImpact

    Change-Id: Ifa6348fa7dfd9de063eb13d30e3ddf94fa530b57