A regression was caused by changing the eventlet.subprocess.Popen
with the builtin subprocess.Popen (by using the nova.utils execute
method) without changing the way the arguments were parsed.
In the v1 volume utilities module, the execution args were parsed
separated by whitespaces, which is not allowed by the builtin
subprocess.Popen, causing a "not found" error.
This error is returned for example when attaching a volume, at the
point where iscsicli tool is used to login the iSCSI target or portal.
This patch fixes the issue by simply splitting the args.
Closes-bug: #1317180
Change-Id: Iee7d5de0dde8b68d8f2bab4214e9b6779ad9f722
(cherry picked from commit 40a790c32ee4ea7b9d79e259545f07409fd618fa)
Reviewed: https:/ /review. openstack. org/93351 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=f769bf8d843 ca6d3530e92e2ab 93c66b1a0cc8c1
Committed: https:/
Submitter: Jenkins
Branch: stable/icehouse
commit f769bf8d843ca6d 3530e92e2ab93c6 6b1a0cc8c1
Author: Lucian Petrut <email address hidden>
Date: Wed May 7 19:43:27 2014 +0300
Fixes arguments parsing when executing command
A regression was caused by changing the eventlet. subprocess. Popen
with the builtin subprocess.Popen (by using the nova.utils execute
method) without changing the way the arguments were parsed.
In the v1 volume utilities module, the execution args were parsed Popen, causing a "not found" error.
separated by whitespaces, which is not allowed by the builtin
subprocess.
This error is returned for example when attaching a volume, at the
point where iscsicli tool is used to login the iSCSI target or portal.
This patch fixes the issue by simply splitting the args.
Closes-bug: #1317180
Change-Id: Iee7d5de0dde8b6 8d8f2bab4214e9b 6779ad9f722 b9d79e259545f07 409fd618fa)
(cherry picked from commit 40a790c32ee4ea7