Change the comments of SOFT_DELETED race condition
_reclaim_queued_deletes will only find instances in SOFT_DELETED
state and delete them if they are only old enough. The quotas will be
committed when the instance was soft-deleted so that resource can
be used right after the soft-delete operation.
There are some concern about the quota inconsistency for the operation,
The only case that the quota might be inconsistent is
the compute node died between set instance state to SOFT_DELETED
and quota commit to DB; when compute node start again
it will have no idea the reservation is committed or not or even
expired, since it's a rare case, so marked as todo.
There are some alternatives if the problem need to be fixed, e.g.
able to find reservation when nova compute restart, so we can double
check whether the quota is committed or not.
Reviewed: https:/ /review. openstack. org/93374 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=1b35a3b263f 47558e2e7791e27 810741881eea43
Committed: https:/
Submitter: Jenkins
Branch: master
commit 1b35a3b263f4755 8e2e7791e278107 41881eea43
Author: jichenjc <email address hidden>
Date: Mon May 12 20:27:43 2014 +0800
Change the comments of SOFT_DELETED race condition
_reclaim_ queued_ deletes will only find instances in SOFT_DELETED
state and delete them if they are only old enough. The quotas will be
committed when the instance was soft-deleted so that resource can
be used right after the soft-delete operation.
There are some concern about the quota inconsistency for the operation,
The only case that the quota might be inconsistent is
the compute node died between set instance state to SOFT_DELETED
and quota commit to DB; when compute node start again
it will have no idea the reservation is committed or not or even
expired, since it's a rare case, so marked as todo.
There are some alternatives if the problem need to be fixed, e.g.
able to find reservation when nova compute restart, so we can double
check whether the quota is committed or not.
Partial-Bug: #1296414
Change-Id: Idf9c179b2dd439 462a646568ffd50 98cd5d7851f